[LTP] [PATCH V2 1/2] tst_timer: Add time64 related helpers

Cyril Hrubis chrubis@suse.cz
Wed Apr 15 13:52:34 CEST 2020


Hi!
> This introduces a new set of helpers to handle the time64 related
> timespec. Instead of duplicating the code, this moves the existing code
> into a macro and then defines timespec and time64 related helpers using
> it.

I'm not sure that adding a macro that spans over ~150 lines is a good
idea. Unfortunately there is not so much options for a C language that
lacks generics.

Maybe it would be slightly better to write a shell script that would
generate these defintions into a separate header that would be included
in the tst_timer.h. That way we can run it manually to regenerate the
header if needed. At least we would get saner error message from
compiler that way.

-- 
chrubis@suse.cz


More information about the ltp mailing list