[LTP] [PATCH v3 1/3] syscalls/pipe2_01: convert into new API

Yang Xu xuyang2018.jy@cn.fujitsu.com
Tue Apr 21 10:27:24 CEST 2020


Hi Li

>     -}
>     +static struct tcase {
>     +       int flags;
>     +       int check_cmd;
> 
> 
> The 'check_cmd' sounds strange here since we don't do any check for the 
> cmd, can we use 'cmd' directly?
Yes.
> 
>     +       int check_read_side;
> 
> 
> A pipe has a read-end and a write-end. So I prefer to call this 
> 'check_read_end', do you agree?
Agree. man-pages also said "the read/write end of the pipe". Thanks for 
pointing out this.
> 
>     +       char *message;
>     +} tcases[] = {




More information about the ltp mailing list