[LTP] [PATCH 2/2] net/sendfile01.sh: Rewrite into new API

Petr Vorel pvorel@suse.cz
Tue Apr 21 19:41:04 CEST 2020


Hi Alexey,

...
> > +	tst_res TINFO "wait for the server to start"
> > +	sleep 1

> It would be better to replace 'sleep' with a wait-loop and check that the
> port in the listen state there, e.g with ss -ltp | grep "$port.*testsf"

I'm sorry, I overlooked this. I'm sorry, merged without this.
I'll implement it separately.
Thanks for your review.

...
> > +		diff $file $lfile > /dev/null
> > +		ret=$?
> > +		if [ $ret -eq 0 ]; then
> > +			tst_res TPASS "coped file is the same as the original"
> > +		elif [ $ret -gt 1 ]; then
> > +			tst_brk TFAIL "cannot compare files"
> > +		else
> > +			tst_res TFAIL "the copied file differs from the original"


> EXPECT_PASS diff $lfile
Fixed.

Kind regards,
Petr


More information about the ltp mailing list