[LTP] [PATCH] lib/tst_hugepage: TCONF when huge pages are not supported

Jan Stancek jstancek@redhat.com
Wed Apr 22 13:33:43 CEST 2020




----- Original Message -----
> >         if (access(PATH_HUGEPAGES, F_OK)) {
> >                 tst_hugepages = 0;
> > -               goto out;
> > +               tst_brk(TCONF, "Huge pages not supported.");
> >
> 
> We don't do that because hugetlb is not the hard requirement for some tests
> (i.e pkey01.c). If we exit with TCONF at an early phase on a non-hugetlb
> system the remaining test will be missed too. In a word, the goto out here
> is on purpose.

Then it's a bit strange it TBROKs if it can't reserve enough huge pages.

I'll send v2, that's checking tst_hugepages. Almost all tests appear to have the 
check already, it just needs to be moved up a little in setup().



More information about the ltp mailing list