[LTP] [PATCH] Add env variable as workaround for test issues in VMs

[Petr Vorel]

Hi,

> > I take a rough look and doubt there is a bug in try_systemd_detect_virt().
> > Shouldn't strncmp() return zero the 'kvm'/'xen' is found?  I guess they
> > wanted:

> Yes, that looks like bug.
Good catch!

> > --- a/lib/tst_virt.c
> > +++ b/lib/tst_virt.c
> > @@ -93,10 +93,10 @@ static int try_systemd_detect_virt(void)
> >         if (ret)
> >                 return 0;

> > -       if (strncmp("kvm", virt_type, 3))
> > +       if (!strncmp("kvm", virt_type, 3))
> >                 return VIRT_KVM;

> > -       if (strncmp("xen", virt_type, 3))
> > +       if (!strncmp("xen", virt_type, 3))
> >                 return VIRT_XEN;

> >         return 0;

> > Apart from that two(kvm/xen) , we need to detect more virtualization tech
> > for ppc/s390 I think.

> We could return VIRT_OTHER by default. We don't really need to
> differentiate which one it is for purpose of this patch.
+1. And if we ever need to differentiate, we can always add them later, using
code from systemd-detect-virt
https://github.com/systemd/systemd/blob/master/src/basic/virt.c

Kind regards,
Petr