[LTP] [PATCH 3/4] syscalls/fanotify15: Add a test case for inode marks
Petr Vorel
pvorel@suse.cz
Mon Apr 27 21:43:28 CEST 2020
Hi Amir,
> for (i = 0, metadata = (struct fanotify_event_metadata *) events_buf;
> FAN_EVENT_OK(metadata, len); i++) {
> @@ -262,7 +323,8 @@ static struct tst_test test = {
> .mount_device = 1,
> .mntpoint = MOUNT_POINT,
> .all_filesystems = 1,
> - .test_all = do_test,
> + .test = do_test,
> + .tcnt = ARRAY_SIZE(test_cases),
> .setup = do_setup,
> .cleanup = do_cleanup
Again, missing (can be added during merge):
- .cleanup = do_cleanup
+ .cleanup = do_cleanup,
+ .tags = (const struct tst_tag[]) {
+ {"linux-git", "f367a62a7cad"},
+ {}
> };
Apart from already mentioned FSID_VAL_MEMBER() LGTM, but again, somebody more
experienced in fanotify and/or filesystems should look into it.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
More information about the ltp
mailing list