[LTP] [PATCH] common_timers: staticize all definitions

Petr Vorel pvorel@suse.cz
Tue Apr 28 08:22:43 CEST 2020


Hi Viresh,

> Staticize all variable and function definitions to avoid build failures
> in the future if this gets included by multiple files.

> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Thanks for a quick fix.

BTW for library files we prefer to have in header include/tst_foo.h just
function signatures and the implementations have in lib/tst_foo.c. Because also
having implementations in include files sometimes bring problems. But for lapi
files (which are included only for some tests) it's perfectly ok.

Kind regards,
Petr


More information about the ltp mailing list