[LTP] [PATCH v2 3/3] syscalls/prctl: Use TST_ASSERT_FILE_INT/STR
Yang Xu
xuyang2018.jy@cn.fujitsu.com
Thu Apr 30 11:58:24 CEST 2020
Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
testcases/kernel/syscalls/prctl/prctl06.c | 20 ++++++--
testcases/kernel/syscalls/prctl/prctl06.h | 29 ++----------
.../kernel/syscalls/prctl/prctl06_execve.c | 13 ++++--
testcases/kernel/syscalls/prctl/prctl07.c | 46 +++++--------------
4 files changed, 39 insertions(+), 69 deletions(-)
diff --git a/testcases/kernel/syscalls/prctl/prctl06.c b/testcases/kernel/syscalls/prctl/prctl06.c
index 0e1274a2a..b64c94e40 100644
--- a/testcases/kernel/syscalls/prctl/prctl06.c
+++ b/testcases/kernel/syscalls/prctl/prctl06.c
@@ -21,16 +21,18 @@
static uid_t nobody_uid;
static gid_t nobody_gid;
+static int proc_flag = 1;
+static char proc_sup[20] = "Yes";
static void do_prctl(void)
{
char ipc_env_var[1024];
- char *const argv[] = {BIN_PATH, "After execve, parent process", NULL};
- char *const childargv[] = {BIN_PATH, "After execve, child process", NULL};
+ char *const argv[] = {BIN_PATH, "After execve, parent process", proc_sup, NULL};
+ char *const childargv[] = {BIN_PATH, "After execve, child process", proc_sup, NULL};
char *const envp[] = {ipc_env_var, NULL };
int childpid;
- check_no_new_privs(0, "parent");
+ check_no_new_privs(0, "parent", proc_flag);
TEST(prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0));
if (TST_RET == -1) {
@@ -46,14 +48,14 @@ static void do_prctl(void)
childpid = SAFE_FORK();
if (childpid == 0) {
- check_no_new_privs(1, "After fork, child process");
+ check_no_new_privs(1, "After fork, child process", proc_flag);
execve(BIN_PATH, childargv, envp);
tst_brk(TFAIL | TTERRNO,
"child process failed to execute prctl_execve");
} else {
tst_reap_children();
- check_no_new_privs(1, "parent process");
+ check_no_new_privs(1, "parent process", proc_flag);
execve(BIN_PATH, argv, envp);
tst_brk(TFAIL | TTERRNO,
"parent process failed to execute prctl_execve");
@@ -74,6 +76,7 @@ static void verify_prctl(void)
static void setup(void)
{
struct passwd *pw;
+ int field;
pw = SAFE_GETPWNAM("nobody");
nobody_uid = pw->pw_uid;
@@ -96,6 +99,13 @@ static void setup(void)
tst_brk(TBROK | TTERRNO,
"current environment doesn't permit PR_GET/SET_NO_NEW_PRIVS");
+
+ TEST(FILE_LINES_SCANF(PROC_STATUS, "NoNewPrivs:%d", &field));
+ if (TST_RET == 1) {
+ tst_res(TCONF, "%s doesn't support NoNewPrivs field", PROC_STATUS);
+ proc_flag = 0;
+ strcpy(proc_sup, "No");
+ }
}
static const char *const resfile[] = {
diff --git a/testcases/kernel/syscalls/prctl/prctl06.h b/testcases/kernel/syscalls/prctl/prctl06.h
index 7f5be20bb..227ce3006 100644
--- a/testcases/kernel/syscalls/prctl/prctl06.h
+++ b/testcases/kernel/syscalls/prctl/prctl06.h
@@ -24,30 +24,7 @@
#define BIN_PATH MNTPOINT"/"TESTBIN
#define SUID_MODE (S_ISUID|S_ISGID|S_IXUSR|S_IXGRP|S_IXOTH)
-void check_proc_field(int val, char *name)
-{
- static int flag = 1;
- int field = 0;
-
- if (!flag)
- return;
-
- TEST(FILE_LINES_SCANF(PROC_STATUS, "NoNewPrivs:%d", &field));
- if (TST_RET == 1) {
- tst_res(TCONF,
- "%s doesn't support NoNewPrivs field", PROC_STATUS);
- flag = 0;
- return;
- }
- if (val == field)
- tst_res(TPASS, "%s %s NoNewPrivs field expected %d got %d",
- name, PROC_STATUS, val, field);
- else
- tst_res(TFAIL, "%s %s NoNewPrivs field expected %d got %d",
- name, PROC_STATUS, val, field);
-}
-
-void check_no_new_privs(int val, char *name)
+void check_no_new_privs(int val, char *name, int flag)
{
TEST(prctl(PR_GET_NO_NEW_PRIVS, 0, 0, 0, 0));
if (TST_RET == val)
@@ -58,8 +35,8 @@ void check_no_new_privs(int val, char *name)
tst_res(TFAIL,
"%s prctl(PR_GET_NO_NEW_PRIVS) expected %d got %ld",
name, val, TST_RET);
-
- check_proc_field(val, name);
+ if (flag)
+ TST_ASSERT_FILE_INT(PROC_STATUS, "NoNewPrivs:", val);
}
#endif
diff --git a/testcases/kernel/syscalls/prctl/prctl06_execve.c b/testcases/kernel/syscalls/prctl/prctl06_execve.c
index d1e60e6c2..cca261ac4 100644
--- a/testcases/kernel/syscalls/prctl/prctl06_execve.c
+++ b/testcases/kernel/syscalls/prctl/prctl06_execve.c
@@ -12,14 +12,19 @@
int main(int argc, char **argv)
{
struct passwd *pw;
+ int proc_flag;
pw = SAFE_GETPWNAM("nobody");
tst_reinit();
- if (argc != 2)
- tst_brk(TFAIL, "argc is %d, expected 2", argc);
-
- check_no_new_privs(1, argv[1]);
+ if (argc != 3)
+ tst_brk(TFAIL, "argc is %d, expected 3", argc);
+
+ if (!strcmp(argv[2], "Yes"))
+ proc_flag = 1;
+ else
+ proc_flag = 0;
+ check_no_new_privs(1, argv[1], proc_flag);
TEST(getegid());
if (TST_RET == 0)
diff --git a/testcases/kernel/syscalls/prctl/prctl07.c b/testcases/kernel/syscalls/prctl/prctl07.c
index 79f7710a8..a6f23a098 100644
--- a/testcases/kernel/syscalls/prctl/prctl07.c
+++ b/testcases/kernel/syscalls/prctl/prctl07.c
@@ -34,36 +34,9 @@
#include "tst_test.h"
#define PROC_STATUS "/proc/self/status"
-
-#ifdef HAVE_SYS_CAPABILITY_H
-static void check_proc_capamb(char *message, int flag)
-{
- int cap_num;
- char CapAmb[20];
-
- SAFE_FILE_LINES_SCANF(PROC_STATUS, "CapAmb:%s", CapAmb);
- cap_num = strtol(CapAmb, NULL, 16);
- if (flag == 2) {
- if (cap_num == 0)
- tst_res(TPASS,
- "%s, %s CapAmb has been clear as %d",
- message, PROC_STATUS, cap_num);
- else
- tst_res(TFAIL,
- "%s, %s CapAmb has been clear expect 0, got %d",
- message, PROC_STATUS, cap_num);
- return;
- }
- if (cap_num == (1 << CAP_NET_BIND_SERVICE))
- tst_res(flag ? TPASS : TFAIL,
- "%s, CapAmb in %s has CAP_NET_BIND_SERVICE",
- message, PROC_STATUS);
- else
- tst_res(flag ? TFAIL : TPASS,
- "%s, CapAmb in %s doesn't have CAP_NET_BIND_SERVICE",
- message, PROC_STATUS);
-}
-#endif
+#define ZERO_STRING "0000000000000000"
+/*CAP_NET_BIND_SERVICE stored in the CapAmb field of PROC_STATUS*/
+#define CAP_STRING "0000000000000400"
static inline void check_cap_raise(unsigned int cap, char *message, int fail_flag)
{
@@ -127,7 +100,8 @@ static void verify_prctl(void)
cap_set_flag(caps, CAP_PERMITTED, numcaps, caplist, CAP_SET);
cap_set_proc(caps);
- check_proc_capamb("At the beginning", 0);
+ tst_res(TINFO, "At the beginning");
+ TST_ASSERT_FILE_STR(PROC_STATUS, "CapAmb", ZERO_STRING);
cap_clear_flag(caps, CAP_INHERITABLE);
cap_set_proc(caps);
@@ -148,14 +122,17 @@ static void verify_prctl(void)
/*Even this cap has been in ambient set, raise succeeds and return 0*/
check_cap_raise(CAP_NET_BIND_SERVICE, "CAP_NET_BIND_SERIVCE twice", 0);
- check_proc_capamb("After PR_CAP_AMBIENT_RAISE", 1);
+ tst_res(TINFO, "After PR_CAP_AMBIENT_RAISE");
+ TST_ASSERT_FILE_STR(PROC_STATUS, "CapAmb", CAP_STRING);
check_cap_is_set(CAP_NET_BIND_SERVICE, "CAP_NET_BIND_SERVICE was", 1);
check_cap_is_set(CAP_NET_RAW, "CAP_NET_RAW was", 0);
/*move a cap what was not in ambient set, it also return 0*/
check_cap_lower(CAP_NET_RAW, "CAP_NET_RAW(it wasn't in ambient set)");
check_cap_lower(CAP_NET_BIND_SERVICE, "CAP_NET_BIND_SERVICE(it was in ambient set)");
- check_proc_capamb("After PR_CAP_AMBIENT_LORWER", 0);
+
+ tst_res(TINFO, "After PR_CAP_AMBIENT_LORWER");
+ TST_ASSERT_FILE_STR(PROC_STATUS, "CapAmb", ZERO_STRING);
prctl(PR_CAP_AMBIENT, PR_CAP_AMBIENT_RAISE, CAP_NET_BIND_SERVICE, 0, 0, 0);
tst_res(TINFO, "raise cap for clear");
@@ -165,7 +142,8 @@ static void verify_prctl(void)
else
tst_res(TFAIL | TERRNO, "PR_AMBIENT_CLEAR_ALL failed");
- check_proc_capamb("After PR_CAP_AMBIENT_CLEAN_ALL", 2);
+ tst_res(TINFO, "After PR_CAP_AMBIENT_CLEAR_ALL");
+ TST_ASSERT_FILE_STR(PROC_STATUS, "CapAmb", ZERO_STRING);
cap_free(caps);
#else
--
2.23.0
More information about the ltp
mailing list