[LTP] [PATCH v1 3/3] syscalls/msgrcv09: Add error test for MSG_COPY flag
Yang Xu
xuyang2018.jy@cn.fujitsu.com
Fri Aug 14 07:37:34 CEST 2020
Hi Cyril
> Hi!
>>>> +static struct tst_test test = {
>>>> + .needs_tmpdir = 1,
>>>> + .needs_root = 1,
>>>> + .needs_kconfigs = (const char *[]) {
>>>> + "CONFIG_CHECKPOINT_RESTORE",
>>>> + NULL
>>>> + },
>>>> + .min_kver = "3.8.0",
>>>> + .tcnt = ARRAY_SIZE(tcases),
>>>> + .test = verify_msgrcv,
>>>> + .setup = setup,
>>>> + .cleanup = cleanup,
>>>> +};
>>>
>>> Do we need both min_kver and CONFIG_CHECKPOINT_RESTORE? Wouldn't be
>>> CONFIG_CHECKPOINT_RESTORE enough?
>> I think we need both because the CONFIG_CHECKPOINT_RESTORE macro was not
>> introduced since 3.8. Before 3.8, we can enable this config but the
>> kernel does not support this MSG_COPY FLAG.
>> also using "CONFIG_CHECKPOINT_RESTORE=y" is better.
>
> Ah, makes sense. I wonder if this worth a comment in the top level
> test description.
In my personal habit, I think a comment is better becuase this is more
friendly for user.
>
More information about the ltp
mailing list