[LTP] [PATCH] Drop the mem01 test

[Li Wang]

On Mon, Aug 17, 2020 at 11:47 AM Yang Xu <xuyang2018.jy@cn.fujitsu.com>
wrote:

> Hi Li
>
>
> >
> >
> > On Mon, Aug 10, 2020 at 4:24 PM Jan Stancek <jstancek@redhat.com
> > <mailto:jstancek@redhat.com>> wrote:
> >
> >
> >     ----- Original Message -----
> >      > The mem01 test often fails on PPC systems mainly because it
> >     doesn't take into
> >      > account page sizes larger than 4KB. Test scenario review revealed
> >     that it's
> >      > not particularly useful because it doesn't have any more specific
> >     goal than
> >      > filling large amount of memory and the hardcoded allocation
> >     limits are too
> >      > low for modern and future systems. The useful part of this test
> >     mostly
> >      > overlaps with coverage by existing OOM tests.
> >      >
> >      > Signed-off-by: Martin Doucha <mdoucha@suse.cz
> >     <mailto:mdoucha@suse.cz>>
> >
> >     Acked-by: Jan Stancek <jstancek@redhat.com <mailto:
> jstancek@redhat.com>>
> >
> > Pushed, thanks!
> >
> [root@localhost ltp]# git grep mem01
> testcases/kernel/syscalls/ioctl/ioctl_sg01.c: * a read-accessible
> SCSI-compatible device (e.g. SATA disk). Running mem01
> [root@localhost ltp]#
>
> ioctl_sg01.c has such description " Running mem01
>   * test program before this one may increase the chance of successfully
>   * reproducing the bug."
>
> I guess we should also remove this or use oom testcases can also
> increase this rate(I don't try ).
>

Good catch, I will help submit a patch to fix that code comment.

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200817/5e323fd6/attachment.htm>