[LTP] [PATCH v3 1/1] tst_kvcmp: Strip double quotes when parsing /etc/os-release

Po-Hsu Lin po-hsu.lin@canonical.com
Thu Aug 20 16:57:06 CEST 2020


LGTM,
Tested with crafted ID, it can correctly parse the ID with or without
the double quote.

Another thing to note is that I found the loop in tst_kvercmp2 could
iterate outside the size of "vers" and causing
tst_test.c:1298: BROK: Test killed by SIGSEGV!

Reviewed-by: Po-Hsu Lin <po-hsu.lin@canonical.com>

On Thu, Aug 20, 2020 at 9:45 PM Cyril Hrubis <chrubis@suse.cz> wrote:
>
> Hi!
> Looks good to me.
>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
>
> --
> Cyril Hrubis
> chrubis@suse.cz


More information about the ltp mailing list