[LTP] [PATCH v3 1/1] tst_kvcmp: Strip double quotes when parsing /etc/os-release

Po-Hsu Lin po-hsu.lin@canonical.com
Fri Aug 21 05:10:03 CEST 2020


On Fri, Aug 21, 2020 at 4:33 AM Petr Vorel <pvorel@suse.cz> wrote:
>
> Hi Po-Hsu,
>
> > LGTM,
> > Tested with crafted ID, it can correctly parse the ID with or without
> > the double quote.
>
> > Another thing to note is that I found the loop in tst_kvercmp2 could
> > iterate outside the size of "vers" and causing
> > tst_test.c:1298: BROK: Test killed by SIGSEGV!
> Will you post the patch for this?
>
> > Reviewed-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> I'm sorry, I've merged it before, but forget to notify.
> Is the bug mentioned above related to my commit?
Hello Petr,
Don't worry it's not related to this commit :)
I will have a look at that bug.

Cheers
>
> Kind regards,
> Petr


More information about the ltp mailing list