[LTP] [PATCH] tst_af_alg: fix build error when ALG_SET_AEAD_ASSOCLEN undefined

Yang Xu xuyang2018.jy@cn.fujitsu.com
Fri Aug 28 11:34:46 CEST 2020


Hi Petr

> Hi,
> 
> ...
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -193,6 +193,12 @@ AC_CHECK_TYPES([struct xt_entry_match, struct xt_entry_target],,,[
>>   #include <linux/netfilter_ipv4/ip_tables.h>
>>   ])
> 
>> +AC_CHECK_TYPES([struct sockaddr_alg, struct af_alg_iv],,,[
>> +#ifdef HAVE_LINUX_IF_ALG_H
>> +# include <linux/if_alg.h>
>> +#endif
> IMHO <linux/if_alg.h> does not need to be guarded.
> (as the definitions are in it it either fail because missing or fail because not
> loaded)
>> +])
Yes. Do you merge this patch with deleting this ifdef? Or I sent a v2 
patch for this.

Also, I think you can remove" #ifdef HAVE_LINUX_IF_PACKET_H" pair in 
configure.ac
AC_CHECK_TYPES([struct tpacket_req3],,,[
#ifdef HAVE_LINUX_IF_PACKET_H
# include <linux/if_packet.h>
#endif
])

Best Regards
Yang Xu

>> +
>>   # Tools knobs
> ...
> 
> Kind regards,
> Petr
> 
> 




More information about the ltp mailing list