[LTP] [PATCH v2 1/3] hotplug/memory_hotplug: Handle NULL returned by strtok_r when parsing inputs

[Li Wang]

Hi Suren,

On Fri, Aug 21, 2020 at 7:41 AM Suren Baghdasaryan <surenb@google.com>
wrote:

> Hi Li,
>
> On Thu, Aug 20, 2020 at 2:16 AM Li Wang <liwang@redhat.com> wrote:
> >
> > Hi Yuan,
> >
> > Thanks for contributing to the memory-hotplug test. I have no objection
> to these patches, but it seems quite a long time(since it imported to LTP
> from Linux foundation at the year 2008) nobody actually touches this memtoy
> except some code cleanup work.
> >
> > I'm wondering whether you guys play with the memtoy regularly? and how
> do you use it?
>
> We did use memtoy to run memory experiments on Android (required some
> minor tweaks to be able to build on Android). After Yuan's fixes we
> were able to use it quite successfully.
>

Ok, I helped merge the patchset after testing. Thanks.


>
> >
> > I take a rough look at the README file but got nothing useful to get a
> start.
>
> You can see one of the scripts Yuan developed to ramp up memory
> allocations of a given type (anon/file-backed/ion) using memtoy here:
>
> https://android-review.googlesource.com/c/platform/external/ltp/+/1344879/44/testcases/kernel/hotplug/memory_hotplug/Scripts/ramp.sh
> The usage is currently for experimentation only but we find it pretty
> handy and we would like to keep using it in the future.
>

Yes, it also looks good to me. Maybe you can consider to upstreaming the
ramp.sh too.

-- 
Regards,
Li Wang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20200831/360976e2/attachment.htm>