[LTP] [PATCH v5 07/10] fanotify: Introduce SAFE_FANOTIFY_MARK() macro

Cyril Hrubis chrubis@suse.cz
Wed Dec 2 16:55:19 CET 2020


Hi!
> +static inline int safe_fanotify_mark(const char *file, const int lineno,
> +			int fd, unsigned int flags, uint64_t mask,
> +			int dfd, const char *pathname)
> +{
> +	int rval;
> +
> +	rval = fanotify_mark(fd, flags, mask, dfd, pathname);
> +
> +	if (rval == -1) {
> +		tst_brk_(file, lineno, TBROK | TERRNO, "fanotify_mark() failed");

I would be a bit more verbose here, i.e. print the mask, pathname and
file descriptors as well.

Otherwise:

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>


-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list