[LTP] [PATCH v1] openposix/fork/7-1.c: A bug fix

Cyril Hrubis chrubis@suse.cz
Fri Dec 11 11:53:43 CET 2020


Hi!
> By adding this comment I wanted to stress that the place of "errno =
> 0" is not randomly chosen, to prevent somebody from moving it back to
> the beginning of the file :) But if you find it not necessary, then
> please go ahead.

I think that this still falls under "do not comment the obvious" rule.
We do have more than hundred of testcases that do "errno = 0" and as far
as I can tell none of them includes a comment that says that we cannot
move the code around and I do not think that we should add hundred of
comments into these testcases either.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list