[LTP] [RFC PATCH 1/1] autotools: Move simple definitions out of m4/* to configure.ac

Yang Xu xuyang2018.jy@cn.fujitsu.com
Wed Feb 5 03:30:36 CET 2020


Hi!
> Hi!
>>> IMO, move all simple definitions to configure.ac will make this file mess
>>> likce old .gitnore file. I perfer to add function or header or macro but not
>>> include struct in configure.ac.
>> I think .gitignore files are different because it's content cannot be duplicated
>> when they're split, but m4/ repeated some checks.
>> + we already started to move configuration into configure.ac before
>> (AC_CHECK_HEADERS and AC_CHECK_FUNCS).
>> IMHO it's easier to search/work with single file than in many files with very little
>> content.
> 
> The main reason for having a separate .gitignore files are:
> 
> * To avoid patch collisions that would happen too often
> 
> * When directory is deleted the .gitignore records are removed as well
> 
> * Also the files are much easier to maintain if there are only few
>    entries, as we do not have to find stuff
> 
> 
> In that sense the configure file is different, collisions are generally
> rare and an stuffing things into m4 files is not much cleaner than
> having it directly in the configure.ac
Thanks for your explanation. I see.
> 




More information about the ltp mailing list