[LTP] [PATCH V2 10/10] syscalls/open_tree: New tests

Viresh Kumar viresh.kumar@linaro.org
Thu Feb 20 08:35:48 CET 2020


On 20-02-20, 15:25, Li Wang wrote:
> Viresh Kumar <viresh.kumar@linaro.org> wrote:
> 
> > ...
> > +++ b/testcases/kernel/syscalls/open_tree/open_tree01.c
> > ...
> > +static struct tcase {
> > +       char *name;
> > +       unsigned int flags;
> > +} tcases[] = {
> > +       {"Flag OPEN_TREE_CLONE", OPEN_TREE_CLONE},
> > +       {"Flag OPEN_TREE_CLOEXEC", OPEN_TREE_CLONE | OPEN_TREE_CLOEXEC},
> > +};
> >
> ==> remove Flag
> 
> 
> +++ b/testcases/kernel/syscalls/open_tree/open_tree02.c
> > @@ -0,0 +1,104 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > ...
> > +
> > +       fsmfd = TST_RET;
> > +       TEST(move_mount(fsmfd, "", AT_FDCWD, MNTPOINT,
> > +                       MOVE_MOUNT_F_EMPTY_PATH));
> > +       SAFE_CLOSE(fsmfd);
> > +
> > +       if (TST_RET == -1)
> > +               tst_brk(TBROK | TERRNO, "move_mount() failed");
> > +
> >
> 
> +       ismounted = 1;
> 
> We need to set 'ismounted' variable to 1 here, otherwise, the test will
> break at the second loop.

Last minute change went untested it seems. Sorry about that.

-- 
viresh


More information about the ltp mailing list