[LTP] [PATCHv2 1/3] zram/zram_lib.sh: fix variable name and algorithm retrieval

Petr Vorel pvorel@suse.cz
Fri Feb 21 06:59:36 CET 2020


Hi,

> The compression algorithm was stored into a local variable "algs",
> however the variable name zram_algs was used in the for loop later.

> Unify them with algs so the default zram_algs defined in zram01 won't
> be altered.

> Also, use sed to get rid of the square brackets that indicates the
> compression algorithm currently in use.
>     $ cat /sys/block/zram0/comp_algorithm
>     [lzo] lz4 lz4hc 842 zstd

> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
>  testcases/kernel/device-drivers/zram/zram_lib.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

> diff --git a/testcases/kernel/device-drivers/zram/zram_lib.sh b/testcases/kernel/device-drivers/zram/zram_lib.sh
> index d0e7704a8..599e5f0f3 100755
> --- a/testcases/kernel/device-drivers/zram/zram_lib.sh
> +++ b/testcases/kernel/device-drivers/zram/zram_lib.sh
> @@ -98,10 +98,10 @@ zram_compress_alg()

>  	tst_resm TINFO "test that we can set compression algorithm"

> -	local algs="$(cat /sys/block/zram0/comp_algorithm)"
> +	local algs="$(sed 's/[][]//g' /sys/block/zram0/comp_algorithm)"
>  	tst_resm TINFO "supported algs: $algs"
>  	local i=0
> -	for alg in $zram_algs; do
> +	for alg in $algs; do
>  		local sys_path="/sys/block/zram${i}/comp_algorithm"
>  		echo "$alg" >  $sys_path || \
>  			tst_brkm TFAIL "can't set '$alg' to $sys_path"

Sorry for a late reply.

What is the purpose of zram_algs="lzo lzo lzo lzo in zram01.sh?
It should be removed now, right? (as you decided not to set the algorithms to the ones defined in the zram01.sh
test at the end of this function as Cyril suggested at [1]

Kind regards,
Petr

[1] http://lists.linux.it/pipermail/ltp/2019-July/012674.html


More information about the ltp mailing list