[LTP] [PATCH 1/1] request_key04: Use TFAIL instead of TBROK

Xiao Yang yangx.jy@cn.fujitsu.com
Wed Feb 26 13:04:58 CET 2020


On 2020/2/26 19:37, Petr Vorel wrote:
> Hi Li,
>
>>> ...
>>>>> obvious fix which I'd normally merge without sending to ML.
>>>>> But there are 19 tests which use tst_res(TBROK, and at least some of
>>>>> them are affected by this (i.e. don't unconditionally report any result
>>>>> before tst_res(TBROK), so we might want to fix it different way.
>>>> +1 for this fix.
>>> Thanks for your review.
>>>> By the way, do you think it makes sense to add build check parameters for
>>>> tst_res() too? Just like what we do for tst_brk() in commit 0738e3753c51.
>>> IMHO if we agree that tst_res(TBROK) is harmful and should be avoided
>>> entirely,
>> I agree.
>>> I'd be for adding this check.
>
>> In personally, I'd let tst_res() only accept 'TPASS, TFAIL, TINFO, TCONF,
>> TWARN'.
> +1. Cyril, Jan?
Hi Petr,

It is OK for me to add this check. :-)

Thanks,
Xiao Yang
> Kind regards,
> Petr
>





More information about the ltp mailing list