[LTP] [PATCH 1/1] request_key04: Use TFAIL instead of TBROK

[Petr Vorel]

Hi,

> > > > In personally, I'd let tst_res() only accept 'TPASS, TFAIL, TINFO, TCONF,
> > > > TWARN'.
> > > +1. Cyril, Jan?

> > I guess that it does not make much sense to report TBROK and then
> > continue the test. But that all depends on how exactly are these states
> > defined. Have we ever wrote them down?

> > I guess that TPASS and TFAIL are obvious.

> > TINFO is just additional information.

> > TCONF is test skipped.

> > TWARN something went wrong but we decided to continue?
+1

> This appears to be mostly used in cleanup() when something goes wrong.
> So a failure that's not critical, not related to goal of test,
> but still something we want to draw attention to.


> > TBROK something went wrong and we decided to exit?

> We do have following in style-guide.txt:

> Use +TBROK+ when an unexpected failure unrelated to the goal of the testcase
> occurred, and use +TFAIL+ when an unexpected failure related to the goal of
> the testcase occurred.

> I agree that tst_res with TBROK doesn't make much sense. I see TBROK as
> something we can't recover from and need to end the test. Otherwise
> if we want to skip part of test, then TCONF looks more fitting.

Thanks all for their input.
I'll merge this test with your ack and create macro + fix remaining tests
(sent patchset to ML).

Kind regards,
Petr