[LTP] [PATCH V2] syscalls/pidfd_open: Continue with rest of the tests on failure

Xiao Yang yangx.jy@cn.fujitsu.com
Wed Feb 26 15:08:18 CET 2020


On 2020/2/26 7:33, Viresh Kumar wrote:
> With tst_brk(), the tests end immediately while what we want to do here
> is to test rest of the failure tests. Use tst_res() to report result and
> continue with rest of the failure tests.
>
> Signed-off-by: Viresh Kumar<viresh.kumar@linaro.org>
> ---
> V2: Use return, instead of if/else blocks.
>
>   testcases/kernel/syscalls/pidfd_open/pidfd_open02.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/pidfd_open/pidfd_open02.c b/testcases/kernel/syscalls/pidfd_open/pidfd_open02.c
> index d73b5326b3b1..9cdded13525a 100644
> --- a/testcases/kernel/syscalls/pidfd_open/pidfd_open02.c
> +++ b/testcases/kernel/syscalls/pidfd_open/pidfd_open02.c
> @@ -35,14 +35,16 @@ static void run(unsigned int n)
>
>   	if (TST_RET != -1) {
>   		SAFE_CLOSE(TST_RET);
> -		tst_brk(TFAIL, "%s: pidfd_open succeeded unexpectedly (index: %d)",
> +		tst_res(TFAIL, "%s: pidfd_open succeeded unexpectedly (index: %d)",
>   			tc->name, n);
> +		return;
>   	}
>
>   	if (tc->exp_errno != TST_ERR) {
> -		tst_brk(TFAIL | TTERRNO, "%s: pidfd_open() should fail with %s",
> +		tst_res(TFAIL | TTERRNO, "%s: pidfd_open() should fail with %s",
>   			tc->name, tst_strerrno(tc->exp_errno));
> -	}
> +		return;
> +	 }
>
>   	tst_res(TPASS | TTERRNO, "%s: pidfd_open() failed as expected",
>   		tc->name);
  Acked-by: Xiao Yang <ice_yangxiao@163.com>




More information about the ltp mailing list