[LTP] [PATCH v2 1/1] lap/syscalls: Update syscall numbers

Petr Vorel pvorel@suse.cz
Thu Feb 27 07:44:42 CET 2020


Hi Viresh,

> > to sync with the kernel v5.6-rc3.

> This doesn't look right, you missed some text here ?
I dared to change this

Get Syscall numbers in sync with latest Linux kernel source

    This gets the Syscall numbers in sync with latest kernel source.

to this:
lap/syscalls: Update syscall numbers

    to sync with the kernel v5.6-rc3.

=> typo: s/lap/lapi/
Hope you don't mind.

> > As this was performed in some sort of automated way, few extra changes
> > may be noticed while converting from kernel files to LTP, like a
> > different format of defining syscalls or removal of obsolete syscalls.

> > The diff generated against sh.in file is enormous and looks like someone
> > did a mistake while adding the syscall numbers there as they look to be
> > mostly incorrect from 220 to 393. They are fixed as a consequence of
> > this exercise.

> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > [ pvorel: various fixes for 32bit syscalls in 64bit arch and vice versa ]

> Sorry about making these mistakes :(
No problem and thanks for your work.
I sent fixes as a new patch as it might be easier to review for others
(off course, you're the author).
I can be wrong as well, other review is welcome :).

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> > Changes v1->v2:
> > * remove wrong umount in ia64
> > * fixed typo sched_rr_get_interval_ti (=> sched_rr_get_interval_time64)
> > * various fixes for 32bit syscalls in 64bit arch and vice versa

> > TODO: not sure about spu and nospu ABI in powerpc (whether they go to
> > 32 bit or 64 bit or is ignored)

> > === DIFF from v1 ===
> > diff --git include/lapi/syscalls/s390.in include/lapi/syscalls/s390.in
> >  pkey_free 386
> > -semtimedop 392

> Why is this removed ?
arch/s390/kernel/syscalls/syscall.tbl
392	64	semtimedop		sys_semtimedop			-
=> only for 64 bit ABI. s390.in is for 32 bit.

> > diff --git include/lapi/syscalls/s390x.in include/lapi/syscalls/s390x.in
> > index dfb7ee811..88cc9b86b 100644
> > --- include/lapi/syscalls/s390x.in
> > +++ include/lapi/syscalls/s390x.in
> > @@ -10,17 +10,12 @@ link 9
> >  unlink 10
> >  execve 11
> >  chdir 12
> > -time 13
arch/s390/kernel/syscalls/syscall.tbl
13   32		time			-				sys_time32
=> only for 32 bit ABI. s390x.in is for 64 bit.

> And the ones like these..

> Because they are only for 32 bit arch and not 64 ?

> > diff --git include/lapi/syscalls/sparc.in include/lapi/syscalls/sparc.in
> > -sched_rr_get_interval_ti423
> > +sched_rr_get_interval_time64 423

> Really bad that I made these mistakes with my vim tricks.

Kind regards,
Petr


More information about the ltp mailing list