[LTP] [PATCH 2/2] syscalls/vmsplice: Add NONBLOCK testcase
Cyril Hrubis
chrubis@suse.cz
Fri Jan 24 13:07:03 CET 2020
Hi!
Pushed with minor changes, thanks.
* Moved the initial vmsplice() to fill the pipe into the test setup
otherwise the test breaks on -i parameter
* Added curly braces around multiline if/else blocks
since this is prefered by LKML see:
https://www.kernel.org/doc/html/v4.10/process/coding-style.html#placing-braces-and-spaces
* I've put the parent code in the second test out of the else block,
the child does not return, there is no need to execute the rest of the
function in an else block
* Put single empty lines between functions, it's much more readable that
way
Also btw, if you put signed-off-by line after the --- it gets removed,
since everything after --- that is not the actual patch gets ignored, so
the signed-off-by should have been before the block that described the
changes in the commit.
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list