[LTP] [PATCH V4 2/2] syscalls/pidfd_open
Viresh Kumar
viresh.kumar@linaro.org
Mon Jan 27 09:37:48 CET 2020
Add tests to check working of pidfd_open() syscall.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
V3->V4:
- Dropped duplicate headers
- Dropped local variable "fd" and used TST_RET directly.
- Handle failure tests with global variable
- Remove else part after creating child process
- Improved print messages
V2->V3:
- Add pidfd_open03 to syscalls and .gitignore files.
- Use TEST, tst_get_unused_pid, etc.
- Do the failure testing with help of array and .tcnt.
- Improved print messages.
- Removed useless comments.
- Few more minor changes.
V1->V2:
- New test to test failures
- Use SAFE_FORK, checkpoints, etc
- Print error numbers as well.
- Improved print messages.
configure.ac | 1 +
include/lapi/pidfd_open.h | 24 ++++++++
runtest/syscalls | 4 ++
.../kernel/syscalls/pidfd_open/.gitignore | 3 +
testcases/kernel/syscalls/pidfd_open/Makefile | 6 ++
.../kernel/syscalls/pidfd_open/pidfd_open01.c | 27 +++++++++
.../kernel/syscalls/pidfd_open/pidfd_open02.c | 58 +++++++++++++++++++
.../kernel/syscalls/pidfd_open/pidfd_open03.c | 57 ++++++++++++++++++
8 files changed, 180 insertions(+)
create mode 100644 include/lapi/pidfd_open.h
create mode 100644 testcases/kernel/syscalls/pidfd_open/.gitignore
create mode 100644 testcases/kernel/syscalls/pidfd_open/Makefile
create mode 100644 testcases/kernel/syscalls/pidfd_open/pidfd_open01.c
create mode 100644 testcases/kernel/syscalls/pidfd_open/pidfd_open02.c
create mode 100644 testcases/kernel/syscalls/pidfd_open/pidfd_open03.c
diff --git a/configure.ac b/configure.ac
index 50d14967d3c6..1bf0911d88ad 100644
--- a/configure.ac
+++ b/configure.ac
@@ -79,6 +79,7 @@ AC_CHECK_FUNCS([ \
mknodat \
name_to_handle_at \
openat \
+ pidfd_open \
pidfd_send_signal \
pkey_mprotect \
preadv \
diff --git a/include/lapi/pidfd_open.h b/include/lapi/pidfd_open.h
new file mode 100644
index 000000000000..9f532f86e18e
--- /dev/null
+++ b/include/lapi/pidfd_open.h
@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2020 Linaro Limited. All rights reserved.
+ * Author: Viresh Kumar <viresh.kumar@linaro.org>
+ */
+
+#ifndef PIDFD_OPEN_H
+#define PIDFD_OPEN_H
+
+#include <sys/syscall.h>
+#include <sys/types.h>
+
+#include "lapi/syscalls.h"
+
+#include "config.h"
+
+#ifndef HAVE_PIDFD_OPEN
+int pidfd_open(pid_t pid, unsigned int flags)
+{
+ return tst_syscall(__NR_pidfd_open, pid, flags);
+}
+#endif
+
+#endif /* PIDFD_OPEN_H */
diff --git a/runtest/syscalls b/runtest/syscalls
index 1f7598b2fe25..a28a1f2ecd45 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -848,6 +848,10 @@ pause03 pause03
personality01 personality01
personality02 personality02
+pidfd_open01 pidfd_open01
+pidfd_open02 pidfd_open02
+pidfd_open03 pidfd_open03
+
pidfd_send_signal01 pidfd_send_signal01
pidfd_send_signal02 pidfd_send_signal02
pidfd_send_signal03 pidfd_send_signal03
diff --git a/testcases/kernel/syscalls/pidfd_open/.gitignore b/testcases/kernel/syscalls/pidfd_open/.gitignore
new file mode 100644
index 000000000000..e0b8900c1c33
--- /dev/null
+++ b/testcases/kernel/syscalls/pidfd_open/.gitignore
@@ -0,0 +1,3 @@
+pidfd_open01
+pidfd_open02
+pidfd_open03
diff --git a/testcases/kernel/syscalls/pidfd_open/Makefile b/testcases/kernel/syscalls/pidfd_open/Makefile
new file mode 100644
index 000000000000..5ea7d67db123
--- /dev/null
+++ b/testcases/kernel/syscalls/pidfd_open/Makefile
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+top_srcdir ?= ../../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/kernel/syscalls/pidfd_open/pidfd_open01.c b/testcases/kernel/syscalls/pidfd_open/pidfd_open01.c
new file mode 100644
index 000000000000..93bb86687a78
--- /dev/null
+++ b/testcases/kernel/syscalls/pidfd_open/pidfd_open01.c
@@ -0,0 +1,27 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2020 Viresh Kumar <viresh.kumar@linaro.org>
+ *
+ * Description:
+ * Basic pidfd_open() test, fetches the PID of the current process and tries to
+ * get its file descriptor.
+ */
+#include "tst_test.h"
+#include "lapi/pidfd_open.h"
+
+static void run(void)
+{
+ TEST(pidfd_open(getpid(), 0));
+
+ if (TST_RET == -1)
+ tst_brk(TFAIL | TTERRNO, "pidfd_open(getpid(), 0) failed");
+
+ SAFE_CLOSE(TST_RET);
+
+ tst_res(TPASS, "pidfd_open(getpid(), 0) passed");
+}
+
+static struct tst_test test = {
+ .min_kver = "5.3",
+ .test_all = run,
+};
diff --git a/testcases/kernel/syscalls/pidfd_open/pidfd_open02.c b/testcases/kernel/syscalls/pidfd_open/pidfd_open02.c
new file mode 100644
index 000000000000..8a549963e34f
--- /dev/null
+++ b/testcases/kernel/syscalls/pidfd_open/pidfd_open02.c
@@ -0,0 +1,58 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2020 Viresh Kumar <viresh.kumar@linaro.org>
+ *
+ * Description:
+ * Basic pidfd_open() test to test invalid arguments.
+ */
+#include "tst_test.h"
+#include "lapi/pidfd_open.h"
+
+#define INVALID_PID -1
+
+pid_t expired_pid, my_pid, invalid_pid = -1;
+
+static struct tcase {
+ char *name;
+ pid_t *pid;
+ int flags;
+ int exp_errno;
+} tcases[] = {
+ {"expired pid", &expired_pid, 0, ESRCH},
+ {"invalid pid", &invalid_pid, 0, EINVAL},
+ {"invalid flags", &my_pid, 1, EINVAL},
+};
+
+static void setup(void)
+{
+ expired_pid = tst_get_unused_pid();
+ my_pid = getpid();
+}
+
+static void run(unsigned int n)
+{
+ struct tcase *tc = &tcases[n];
+
+ TEST(pidfd_open(*tc->pid, tc->flags));
+
+ if (TST_RET != -1) {
+ SAFE_CLOSE(TST_RET);
+ tst_brk(TFAIL, "%s: pidfd_open succeeded unexpectedly (index: %d)",
+ tc->name, n);
+ }
+
+ if (tc->exp_errno != TST_ERR) {
+ tst_brk(TFAIL | TTERRNO, "%s: pidfd_open() should fail with %s",
+ tc->name, tst_strerrno(tc->exp_errno));
+ }
+
+ tst_res(TPASS | TTERRNO, "%s: pidfd_open() failed as expected",
+ tc->name);
+}
+
+static struct tst_test test = {
+ .min_kver = "5.3",
+ .tcnt = ARRAY_SIZE(tcases),
+ .test = run,
+ .setup = setup,
+};
diff --git a/testcases/kernel/syscalls/pidfd_open/pidfd_open03.c b/testcases/kernel/syscalls/pidfd_open/pidfd_open03.c
new file mode 100644
index 000000000000..48470e5e1d43
--- /dev/null
+++ b/testcases/kernel/syscalls/pidfd_open/pidfd_open03.c
@@ -0,0 +1,57 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2020 Viresh Kumar <viresh.kumar@linaro.org>
+ *
+ * Description:
+ * This program opens the PID file descriptor of the child process created with
+ * fork(). It then uses poll to monitor the file descriptor for process exit, as
+ * indicated by an EPOLLIN event.
+ */
+#include <poll.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "tst_test.h"
+#include "lapi/pidfd_open.h"
+
+static void run(void)
+{
+ struct pollfd pollfd;
+ int fd, ready;
+ pid_t pid;
+
+ pid = SAFE_FORK();
+
+ if (!pid) {
+ TST_CHECKPOINT_WAIT(0);
+ exit(EXIT_SUCCESS);
+ }
+
+ TEST(pidfd_open(pid, 0));
+
+ fd = TST_RET;
+ if (fd == -1)
+ tst_brk(TFAIL | TTERRNO, "pidfd_open() failed");
+
+ TST_CHECKPOINT_WAKE(0);
+
+ pollfd.fd = fd;
+ pollfd.events = POLLIN;
+
+ ready = poll(&pollfd, 1, -1);
+
+ SAFE_CLOSE(fd);
+ SAFE_WAITPID(pid, NULL, 0);
+
+ if (ready != 1)
+ tst_res(TFAIL, "poll() returned %d", ready);
+ else
+ tst_res(TPASS, "pidfd_open() passed");
+}
+
+static struct tst_test test = {
+ .min_kver = "5.3",
+ .test_all = run,
+ .forks_child = 1,
+ .needs_checkpoints = 1,
+};
--
2.21.0.rc0.269.g1a574e7a288b
More information about the ltp
mailing list