[LTP] [PATCH V7 09/19] syscalls/sigwaitinfo: Migrate to new test framework

Viresh Kumar viresh.kumar@linaro.org
Mon Jul 6 04:39:41 CEST 2020


On 03-07-20, 15:58, Cyril Hrubis wrote:
> Hi!
> Honestly I'm not sure what we should do about this test. Obviously this
> is a step into right direction but it still keeps the SUCCEED_OR_DIE()
> macro that produces many warnings.
> 
> I'm also not happy about the fact that we compile different test based
> on ifdefs and that there are empty directories where binaries are
> magically appear during the build. I would be much happier if we had a
> real test sources there and share the large enough common bits in a
> different way.

What about merging this patch as is (so I don't to keep sending it)
and then I fix all the issues you want to get fixed in this test
separately ?

I agree with the issues you raised. It took me a while to understand
how it tests different syscalls and how things magically work in
multiple directories :)

-- 
viresh


More information about the ltp mailing list