[LTP] [PATCH] lapi/io_uring.h: Add declaration of __kernel_rwf_t

Petr Vorel pvorel@suse.cz
Fri Jul 17 10:08:40 CEST 2020


> > Since kernel commit ddef7ed2b5cb ("annotate RWF_... flags"), fs.h introduced
> >  __kernel_rwf_t data type in 4.14-rc1.
> >
> > Fix build error on old kernel.

> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Thanks for the fix.
> Going to merge it, just wait for travis verification.
BTW the regression was caused by my changes to the lapi header in 95399bc87
("lapi/io_uring: Preparation for io_uring tests") - I updated the header.

We might consider not including <linux/types.h>, it's needed just for
__kernel_rwf_t. I'm against these optimisations (as the definition can change),
but I remember Jan asked me to avoid including kernel header just for single use
[1], but maybe this is a different case.

Kind regards,
Petr

[1] https://patchwork.ozlabs.org/project/ltp/patch/20191016211501.3777-1-petr.vorel@gmail.com/#2281586


More information about the ltp mailing list