[LTP] [PATCH 4/4] libs: sigwait: Get rid of REPORT_SUCCESS() macro
Petr Vorel
pvorel@suse.cz
Fri Jul 24 07:58:26 CEST 2020
Hi Viresh,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Although these errors are still here:
sigwait.c: In function ‘test_masked_matching’:
sigwait.c:157:42: warning: passing argument 3 to restrict-qualified parameter aliases with argument 2 [-Wrestrict]
157 | TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask));
| ~~~~~~~~ ^~~~~~~~
../../include/tst_test.h:266:13: note: in definition of macro ‘TEST’
266 | TST_RET = SCALL; \
| ^~~~~
sigwait.c: In function ‘test_masked_matching_rt’:
sigwait.c:226:42: warning: passing argument 3 to restrict-qualified parameter aliases with argument 2 [-Wrestrict]
226 | TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask));
| ~~~~~~~~ ^~~~~~~~
../../include/tst_test.h:266:13: note: in definition of macro ‘TEST’
266 | TST_RET = SCALL; \
| ^~~~~
sigwait.c: In function ‘test_masked_matching_noinfo’:
sigwait.c:265:42: warning: passing argument 3 to restrict-qualified parameter aliases with argument 2 [-Wrestrict]
265 | TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask));
| ~~~~~~~~ ^~~~~~~~
../../include/tst_test.h:266:13: note: in definition of macro ‘TEST’
266 | TST_RET = SCALL; \
| ^~~~~
sigwait.c: In function ‘test_bad_address’:
sigwait.c:312:42: warning: passing argument 3 to restrict-qualified parameter aliases with argument 2 [-Wrestrict]
312 | TEST(sigprocmask(SIG_SETMASK, &oldmask, &oldmask));
| ~~~~~~~~ ^~~~~~~~
IMHO we shouldn't use oldmask for src and dest.
Kind regards,
Petr
More information about the ltp
mailing list