[LTP] [PATCH 1/1] semctl: Fix 32 bit build

Cyril Hrubis chrubis@suse.cz
Thu Jul 30 11:48:42 CEST 2020


Hi!
>  testcases/kernel/syscalls/ipc/semctl/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/ipc/semctl/Makefile b/testcases/kernel/syscalls/ipc/semctl/Makefile
> index 99971a7db..2559b4c28 100644
> --- a/testcases/kernel/syscalls/ipc/semctl/Makefile
> +++ b/testcases/kernel/syscalls/ipc/semctl/Makefile
> @@ -8,6 +8,6 @@ LTPLIBS = ltpipc ltpnewipc
>  include $(top_srcdir)/include/mk/testcases.mk
>  
>  semctl01 semctl02 semctl03 semctl04 semctl05 semctl06 semctl07: LDLIBS += -lltpipc
> -semctl08: LDLIBS += -lltpnewipc
> +semctl08: LDLIBS = -lltpnewipc -lltp

If nothing else this may break things if user passed something in
LDLIBS, so it should be:

LDLIBS = -lltpnewipc $(LDLIBS)


And I guess the safest rule would be to add the -lltp* libraries first,
because naturally none of the code in LTP but the test depends on these.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list