[LTP] [PATCH V2 2/2] libs: sigwait: Get rid of REPORT_SUCCESS() macro

Cyril Hrubis chrubis@suse.cz
Thu Jul 30 17:25:05 CEST 2020


Hi!
> > Unfortunately half of this patch does not apply after the changes in the
> > first one, can you please rebase?
> 
> I didn't see any issues with normal rebase of this patch over the other one, git
> probably resolved issues itself.

Well the original v2 patch contains references to the sigprocmask()
lines that the previous patch changes, what I got bunch of these:

Checking patch libs/libltpsigwait/sigwait.c...
error: while searching for:
        child = create_sig_proc(signo, 1, 0);

        TEST(sigwaitinfo(&sigs, &si, NULL));
        REPORT_SUCCESS_COND(signo, 0, si.si_pid == child
                            && si.si_code == SI_USER
                            && si.si_signo == signo, "Struct siginfo mismatch");

        TEST(sigprocmask(SIG_SETMASK, &sigs, &oldmask));
        if (TST_RET == -1)

Because the sigprocmask(SIG_SETMASK, &sigs, &oldmask)); couldn't be found.

The patch that you resend has corrected these.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list