[LTP] [PATCH] syscalls/ioctl_loop01: Add test for clear loop flag

[Yang Xu]

After loop driver kernel code, I found LO_FLAGS_PARTSCAN can
not be clear and LO_FLAGS_AUTOCLEAR can be clear. Test this.

Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
---
 .../kernel/syscalls/ioctl/ioctl_loop01.c      | 39 ++++++++++++-------
 1 file changed, 24 insertions(+), 15 deletions(-)

diff --git a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
index 2d9733f95..3a33f2035 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_loop01.c
@@ -13,6 +13,9 @@
  * But we also check whether we can scan partition table correctly ie check
  * whether /dev/loopnp1 and /sys/bloclk/loop0/loop0p1 existed.
  *
+ * For LO_FLAGS_AUTOCLEAR flag, it can be clear. For LO_FLAGS_PARTSCAN flag,
+ * it cannot be clear. We also check this.
+ *
  * It is also a regression test for kernel
  * commit 10c70d95c0f2 ("block: remove the bd_openers checks in blk_drop_partitions").
  */
@@ -38,10 +41,26 @@ static int dev_num, attach_flag, dev_fd, parted_sup;
 static char partscan_path[1024], autoclear_path[1024];
 static char loop_partpath[1026], sys_loop_partpath[1026];
 
+static void check_loop_flag(int set_flag, int get_flag, int autoclear_field)
+{
+	struct loop_info loopinfo = {0}, loopinfoget = {0};
+
+	loopinfo.lo_flags = set_flag;
+	SAFE_IOCTL(dev_fd, LOOP_SET_STATUS, &loopinfo);
+	SAFE_IOCTL(dev_fd, LOOP_GET_STATUS, &loopinfoget);
+
+	if (loopinfoget.lo_flags & ~get_flag)
+		tst_res(TFAIL, "expect %d but got %d", get_flag, loopinfoget.lo_flags);
+	else
+		tst_res(TPASS, "get expected lo_flag %d", loopinfoget.lo_flags);
+
+	TST_ASSERT_INT(partscan_path, 1);
+	TST_ASSERT_INT(autoclear_path, autoclear_field);
+}
+
 static void verify_ioctl_loop(void)
 {
 	int ret;
-	struct loop_info loopinfo, loopinfoget;
 
 	tst_attach_device(dev_path, "test.img");
 	attach_flag = 1;
@@ -51,21 +70,8 @@ static void verify_ioctl_loop(void)
 	TST_ASSERT_STR(backing_path, backing_file_path);
 
 	dev_fd = SAFE_OPEN(dev_path, O_RDWR);
-	memset(&loopinfo, 0, sizeof(loopinfo));
-	memset(&loopinfoget, 0, sizeof(loopinfoget));
-
-	loopinfo.lo_flags = SET_FLAGS;
-	SAFE_IOCTL(dev_fd, LOOP_SET_STATUS, &loopinfo);
-
-	SAFE_IOCTL(dev_fd, LOOP_GET_STATUS, &loopinfoget);
 
-	if (loopinfoget.lo_flags & ~GET_FLAGS)
-		tst_res(TFAIL, "expect %d but got %d", GET_FLAGS, loopinfoget.lo_flags);
-	else
-		tst_res(TPASS, "get expected lo_flag %d", loopinfoget.lo_flags);
-
-	TST_ASSERT_INT(partscan_path, 1);
-	TST_ASSERT_INT(autoclear_path, 1);
+	check_loop_flag(SET_FLAGS, GET_FLAGS, 1);
 
 	if (!parted_sup) {
 		tst_res(TINFO, "Current environment doesn't have parted disk, skip it");
@@ -84,6 +90,9 @@ static void verify_ioctl_loop(void)
 	else
 		tst_res(TFAIL, "access %s fails", sys_loop_partpath);
 
+	tst_res(TINFO, "Test flag can be clear");
+	check_loop_flag(0, LO_FLAGS_PARTSCAN, 0);
+
 detach_device:
 	SAFE_CLOSE(dev_fd);
 	tst_detach_device(dev_path);
-- 
2.23.0