[LTP] [PATCH 4/8] syscalls/sysinfo03: Add time namespace test

Cyril Hrubis chrubis@suse.cz
Mon Mar 9 14:33:02 CET 2020


Hi!
> >> > +static struct tst_test test = {
> >> > +	.tcnt = ARRAY_SIZE(offsets),
> >> > +	.test = verify_sysinfo,
> >> > +	.needs_root = 1,
> >> > +	.forks_child = 1,
> >> > +	.needs_kconfigs = (const char *[]) {
> >> > +		"CONFIG_TIME_NS=y"
> >> > +	}
> >> > +};
> >>
> >> Will you add a git ref when the fix is in mainline/for-next?
> >>
> >> Should be safe to add it as soon as it is in the for-next tree.
> >
> > I'm not sure how usefull that will be because the fix should get in
> > during the RC phase the functionality was introduced, so technically the
> > missing support of sysinfo() in time namespaces should not reach any
> > officially released kernel.
> 
> What is the downside to including it?
> 
> Also, I can imagine some people will try backporting this and may miss
> something not in the original patch set.

Okay, that's a valid reason to include the hash.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list