[LTP] [PATCH V6 05/10] syscalls/fsconfig: New tests

Cyril Hrubis chrubis@suse.cz
Thu Mar 12 20:10:25 CET 2020


Hi!
Pushed with two minor changes:

diff --git a/testcases/kernel/syscalls/fsconfig/fsconfig01.c b/testcases/kernel/syscalls/fsconfig/fsconfig01.c
index d05350ce2..aea6db822 100644
--- a/testcases/kernel/syscalls/fsconfig/fsconfig01.c
+++ b/testcases/kernel/syscalls/fsconfig/fsconfig01.c
@@ -77,6 +77,8 @@ static void run(void)
                SAFE_UMOUNT(MNTPOINT);
                tst_res(TPASS, "fsconfig() passed");
        }
+
+       SAFE_CLOSE(fd);
 }

We need to close the fd here, because the test will run out of file
descriptors for large enough -i parameter, since cleanup is executed
only at the test end. Also note that SAFE_CLOSE() sets the fd to -1 so
that cleanup is no-op unless we trigger some of the tst_brk()
statements.

 static struct tst_test test = {
diff --git a/testcases/kernel/syscalls/fsconfig/fsconfig02.c b/testcases/kernel/syscalls/fsconfig/fsconfig02.c
index b07a5f3ab..586524f14 100644
--- a/testcases/kernel/syscalls/fsconfig/fsconfig02.c
+++ b/testcases/kernel/syscalls/fsconfig/fsconfig02.c
@@ -94,6 +94,7 @@ static struct tst_test test = {
        .test = run,
        .setup = setup,
        .cleanup = cleanup,
+       .needs_tmpdir = 1,
        .needs_root = 1,
        .needs_device = 1,
 };

The test creates a file hence it has to request temporary directory.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list