[LTP] [PATCH V6 05/10] syscalls/fsconfig: New tests

[Cyril Hrubis]

Hi!
> > diff --git a/testcases/kernel/syscalls/fsconfig/fsconfig01.c b/testcases/kernel/syscalls/fsconfig/fsconfig01.c
> > index d05350ce2..aea6db822 100644
> > --- a/testcases/kernel/syscalls/fsconfig/fsconfig01.c
> > +++ b/testcases/kernel/syscalls/fsconfig/fsconfig01.c
> > @@ -77,6 +77,8 @@ static void run(void)
> >                 SAFE_UMOUNT(MNTPOINT);
> >                 tst_res(TPASS, "fsconfig() passed");
> >         }
> > +
> > +       SAFE_CLOSE(fd);
> 
> This isn't required as cleanup() routine is taking care of it and this
> is a test_all type test.

It _is_, I've tried top explain in the paragraph below, just run the
test with large enough -i, sooner or late the test will run out of file
descriptiors and then it will fail.

The key here is that the run() function can be called repeatedly but
setup() and cleanup() are called only once at the start and at the end
of the test.

> > We need to close the fd here, because the test will run out of file
> > descriptors for large enough -i parameter, since cleanup is executed
> > only at the test end. Also note that SAFE_CLOSE() sets the fd to -1 so
> > that cleanup is no-op unless we trigger some of the tst_brk()
> > statements.

-- 
Cyril Hrubis
chrubis@suse.cz