[LTP] [PATCH] pthread_cond_init/s-c.c: Add the lose ifndef line

[Yang Xu]

Hi Enji


> Hi Yang,
> 	I’ll have to look back, but this might have been the original set of items which never compiled/built cleanly.
I guess commit bec80d891a ("Fix oversight with `test tools'") changed 
this, as below:

--- a/testcases/open_posix_testsuite/scripts/locate-test
+++ b/testcases/open_posix_testsuite/scripts/locate-test
...
-       find "$WHERE" -type f -name '*.c' -o -name '[0-9]*-[0-9]*.sh' | 
grep -v buildonly | grep -v '^./tools' | grep -v testfrmw | grep -v 
'_scenarii'
+       find "$WHERE" -type f -name '*[0-9].c' -o -name 
'[0-9]*-[0-9]*.sh' | grep -v buildonly | grep -v '^./tools'

> 	I think it’s time to go back to a more sane gmake-based build framework. My goal in making things work with POSIX make was noble for the time but it seems incredibly unnecessary now and I think it’s overcomplicating things.
Yes. We should refactor this with using gmake, at lease we should 
compile them automatically.

Best Regards
Yang Xu
> Thanks!
> -Enji
> 
>> On Mar 16, 2020, at 12:53 AM, Yang Xu <xuyang2018.jy@cn.fujitsu.com> wrote:
>>
>> Hi Cyril
>>
>> On my environment, when I test openposix, this case missed run and complie because locate-test has filter rules called by open_posix_testsuite/scripts/generate-makefiles.sh.  filter rules as below:
>>
>> runnable)
>>         find "$WHERE/conformance" "$WHERE/stress" -type f -name '*[0-9].c' -o -name '[0-9]*-[0-9]*.sh' | grep -v buildonly | grep -v '^./tools'
>>         find "$WHERE/functional" -type f -name '*.c'
>>
>> I have a question why we leave it here if they are no meaningful. If
>> it was meaningful, why we filter this case? I see the history, but found no thing.
>>
>> @Enji, you often change openposix code, can you give me some advise?
>>
>> Best Regards
>> Yang Xu
>>
>>> Hi Zou
>>> It was introduced by commit 310c9eb6e6("Remove explicit #define's for `_POSIX_C_SOURCE` and `_XOPEN_SOURCE`").
>>> IMO, we can remove this WITHOUT_XOPEN macro directly because we have setted -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700 in ltp/testcases/open_posix_testsuite/CFLAGS.
>>> Best Regards
>>> Yang Xu
>>>> pthread_cond_init/s-c.c testcase lose a #ifndef line, fix it
>>>>
>>>> Reported-by: Zou Wei <zou_wei@huawei.com>
>>>> Signed-off-by: Zou Wei <zou_wei@huawei.com>
>>>> ---
>>>>   testcases/open_posix_testsuite/stress/threads/pthread_cond_init/s-c.c | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/testcases/open_posix_testsuite/stress/threads/pthread_cond_init/s-c.c b/testcases/open_posix_testsuite/stress/threads/pthread_cond_init/s-c.c
>>>> index 6a5c70a..8d18484 100644
>>>> --- a/testcases/open_posix_testsuite/stress/threads/pthread_cond_init/s-c.c
>>>> +++ b/testcases/open_posix_testsuite/stress/threads/pthread_cond_init/s-c.c
>>>> @@ -80,6 +80,7 @@
>>>>    /***********************************    Test case   *****************************************/
>>>>   /********************************************************************************************/
>>>> +#ifndef WITHOUT_XOPEN
>>>>    typedef struct _teststruct {
>>>>        pthread_cond_t cnd[10 * SCALABILITY_FACTOR];
>>>>        pthread_condattr_t ca[4];
>>>> -- 
>>>> 2.6.2
>>>>
>>>>
>>
>>
> 
> 
>