[LTP] 答复: [PATCH] pthread_cond_init/s-c.c: Add the lose ifndef line

Zouwei (Samuel) zou_wei@huawei.com
Tue Mar 17 08:34:05 CET 2020


Hi Xu

Thanks for merge the patch.

I sent another 2 patches, one is to enable the open_posix_testsuite in the makefile, and the other one is to fix the open_posix compilation issue.

Best Regards
Zou Wei
-----邮件原件-----
发件人: Xiao Yang [mailto:yangx.jy@cn.fujitsu.com] 
发送时间: 2020年3月17日 15:15
收件人: Zouwei (Samuel) <zou_wei@huawei.com>
抄送: ltp@lists.linux.it
主题: Re: [LTP] [PATCH] pthread_cond_init/s-c.c: Add the lose ifndef line

Hi Zou,

Pushed.

BTW:
1) we also need to update open_posix_testsuite so that it can compile these stress tests by default.
2) Your patch seems to be broken so I recreate and apply it.

Thanks,
Xiao Yang
On 2020/3/16 10:58, Zou Wei wrote:
> pthread_cond_init/s-c.c testcase lose a #ifndef line, fix it
>
> Reported-by: Zou Wei<zou_wei@huawei.com>
> Signed-off-by: Zou Wei<zou_wei@huawei.com>
> ---
>   testcases/open_posix_testsuite/stress/threads/pthread_cond_init/s-c.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git 
> a/testcases/open_posix_testsuite/stress/threads/pthread_cond_init/s-c.
> c 
> b/testcases/open_posix_testsuite/stress/threads/pthread_cond_init/s-c.
> c
> index 6a5c70a..8d18484 100644
> --- 
> a/testcases/open_posix_testsuite/stress/threads/pthread_cond_init/s-c.
> c
> +++ b/testcases/open_posix_testsuite/stress/threads/pthread_cond_init/
> +++ s-c.c
> @@ -80,6 +80,7 @@
>   /***********************************    Test case   *****************************************/
>   
> /*********************************************************************
> ***********************/
> +#ifndef WITHOUT_XOPEN
>   typedef struct _teststruct {
>   	pthread_cond_t cnd[10 * SCALABILITY_FACTOR];
>   	pthread_condattr_t ca[4];
> --
> 2.6.2
>
>





More information about the ltp mailing list