[LTP] [PATCH V7 10/10] syscalls/open_tree: New tests

[Cyril Hrubis]

Hi!
> > Here as well, shouldn't we just set the .mount_device flag instead?
> 
> Hi,
> 
> Sorry but I am not sure what will happen by .mount_device here. From
> what I see from tst_test.c, that flag will end up calling SAFE_MOUNT()
> automatically, but what we are calling here is fsmount() and
> move_mount() instead.
> 
> Can you please elaborate a bit on that ? Thanks.

My point here is that most of the code just mounts the device and since
we are testing open_tree() there is no point in mounting the device with
the new mount API in the first half of the run() function, it should
work fine with the device mounted with the plain old mount(). Also we do
OPEN_TREE_CLONE here, so there is no point in mounting the filesystem in
the run() fucntion, moreover it will probably fail with the -i
parameter.

So I'm suggesting to remove the part that mounts the device in the first
half of the test and set the .mount_device flag instead.

-- 
Cyril Hrubis
chrubis@suse.cz