[LTP] [PATCH 2/2] Use SAFE_RUNCMD()

[Yang Xu]

Hi Li


> Hi Petr,
> 
> On Fri, Mar 20, 2020 at 9:50 PM Petr Vorel <pvorel@suse.cz
> <mailto:pvorel@suse.cz>> wrote:
> 
>     Signed-off-by: Petr Vorel <pvorel@suse.cz <mailto:pvorel@suse.cz>>
>     ---
>       testcases/kernel/syscalls/add_key/add_key05.c   | 15 ++-------------
>       testcases/kernel/syscalls/quotactl/quotactl01.c | 14 ++------------
>       testcases/kernel/syscalls/quotactl/quotactl06.c | 12 +-----------
> 
> 
> Apart from the three, do you consider converting to SAFE_RUNCMD for the 
> rest testcases?
> (it seems not too much work remaining since only a few test case uses 
> tst_run_cmd)
At the beginning, I have the same idea. But after seeing code, I think 
we should not because these cases have many sub tests(only few test 
deponds on the result of the cmd execution.
> 
> kernel/syscalls/setpriority/setpriority01.c
One year ago has a commit db82b596(setpriority01: Skip only PRIO_USER 
when unable to add test user). It only affects PRIO_USER sub test.
> kernel/syscalls/copy_file_range/copy_file_range02.c
only affect test6 and test7
  6) Try to copy contents to a file chattred with +i
  *    flag -> EPERM
  * 7) Try to copy contents to a swapfile ->ETXTBSY


Best Regards
Yang Xu

> ...
> 
> 
> -- 
> Regards,
> Li Wang
> 
>