[LTP] [PATCH 0/6] C API: .needs_cmds and SAFE_RUN_CMD()

Xiao Yang ice_yangxiao@163.com
Sat Mar 28 03:41:19 CET 2020


On 3/28/20 5:39 AM, Petr Vorel wrote:
> + There is a double check (first in
> .needs_cmds, then in SAFE_RUN_CMD()), maybe that's not needed.

Hi Petr,

Why do you need the duplicate .needs_cmds flag?(it introduces the double 
check as you said)

Usually, all tests run commands by tst_run_cmd()/SAFE_RUN_CMD() and they 
can report TCONF

by passing TST_RUN_CMD_CHECK_CMD so it is fair to be a part of 
tst_run_cmd()/SAFE_RUN_CMD().

Thanks,

Xiao Yang




More information about the ltp mailing list