[LTP] [PATCH 5/6] lib: Implement SAFE_RUN_CMD() macro (new API only)

Petr Vorel pvorel@suse.cz
Mon Mar 30 10:44:07 CEST 2020


Hi Li,

> Thanks for your work on this.


> > +static inline void safe_run_cmd(const char *file, const int lineno,
Old code. 'static inline' shouldn't be here.

> > +                                                          const char
> > *const argv[],


> Be cautious of the code indent here, otherwise patchset looks good.
Thanks!


> > +                             const char *stdout_path,
> > +                             const char *stderr_path)
> > +{

Kind regards,
Petr


More information about the ltp mailing list