[LTP] [PATCH 3/6] lib/tst_run_cmd_*(): Turn int pass_exit_val into enum

Petr Vorel pvorel@suse.cz
Mon Mar 30 13:40:43 CEST 2020


Hi,

> > This is a preparation for next commit.
> > Now uses the only flag TST_RUN_CMD_PASS_EXIT_VAL.

> That is quite long name, I wonder if we can shorten it.

> Maybe we can rename the whole tst_run_cmd() just to tst_cmd() and change
> this flag to TST_CMD_PASS_RETVAL.
This looks good to me, I'll change it.


> Other that this the patchset looks good.
And push whole patchset with your, Li's and Xiao Reviewed-by: tag.

Kind regards,
Petr


More information about the ltp mailing list