[LTP] [PATCH 4/6] lib/tst_run_cmd_*(): Search for program in $PATH

Cyril Hrubis chrubis@suse.cz
Mon Mar 30 13:53:35 CEST 2020


Hi!
> > > +	/* exit with TCONF if program is not in path */
> > > +	TST_RUN_CMD_CHECK_CMD = 2,
> 
> > Shouldn't be this rather called TST_CMD_TCONF_ON_MISSING?
> +1.
> 
> If these two comments (with renaming to tst_cmd() + flags) are the only your
> concern, I'll rename it and just push without sending to ML.

Yes, minus the comments on the function and constant names the code
lookgs good.

> When we're in renaming, I guess I should rename SAFE_RUN_CMD() into SAFE_CMD(),

Indeed.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list