[LTP] [PATCH V2 01/17] syscalls/timer_gettime: Add support for time64 tests

Arnd Bergmann arnd@arndb.de
Fri May 8 10:30:36 CEST 2020


On Fri, May 8, 2020 at 6:24 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:

> +#if defined(TST_ABI32)
> +       { .func = sys_timer_gettime, .type = TST_LIBC_TIMESPEC, .desc = "syscall with libc spec"},
> +#endif

> +#if defined(TST_ABI64)
> +       { .func = sys_timer_gettime, .type = TST_KERN_TIMESPEC, .desc = "syscall with kernel spec64"},
> +#endif

I think these are both invalid: timer_gettime() does not take a libc timespec or
a __kernel_timespec but takes a __kernel_old_timespec. You should only
use the libc data structure with the libc timer_gettime, and the
__kernel_timespec
with the kernel's timer_gettime64().

        Arnd


More information about the ltp mailing list