[LTP] [PATCH 1/1] rpc: Warn when tests aren't compiled

Petr Vorel pvorel@suse.cz
Tue May 12 21:50:33 CEST 2020


Hi Alexey,

...
> >  rpc_parse_args()
> >  {
> > +	local err="LTP compiled without TI-RPC support"
> > +
> >  	case "$1" in
> > -		c) CLIENT="$OPTARG" ;;
> > -		e) CLIENT_EXTRA_OPTS="$OPTARG" ;;
> > -		s) SERVER="$OPTARG" ;;
> > +	c) CLIENT="$OPTARG"; tst_cmd_available $OPTARG || tst_brk TCONF $err;;
> > +	e) CLIENT_EXTRA_OPTS="$OPTARG";;
> > +	s) SERVER="$OPTARG"; tst_cmd_available $OPTARG || tst_brk TCONF $err;;
> >  	esac

> Perhaps this one, to write about the missing command:
> tst_require_cmds $CLIENT $SERVER

> or just $CLIENT because it's always used, and if the hint is needed:
> tst_check_cmds $CLIENT $SERVER || tst_brk TCONF "LTP compiled without TI-RPC support?"
I prefer to have the hint, so I'll merge this variant.

Thanks for your review!

Kind regards,
Petr


More information about the ltp mailing list