[LTP] [PATCH v2 1/2] syscalls/pidfd_open01.c: Add check for close-on-exec flag

[Petr Vorel]

Hi Yang,

> > To be honest I like this approach, because 1) it defines when new syscall was
> > backported

> Hmm, the reason seems a little weak, it can be done by adding a comment(e.g.
> "the syscall is introduced since v5.6.0").
Sure, that would work as well.

> 2) if there is really problem that some functionality was removed, we
> > can always handle it. But IMHO that's going to be rare (btrfs removed in RHEL 8
> > is IMHO because RHEL does not want to support it, but that would not happen for
> > syscalls).

> Without the rare situation, I also think tst_syscall() is enough to check
> the support of syscall.
Well, nothing that much important, but I'd like to hear the opinion of
other maintainers. BTW We now concentrate on pre-release fixes.

> > I'd also like to be consistent how we handle these new syscalls.
> Agreed.

> I also think if we can implement common func(e.g.
> syscall_supported_by_kernel()).
Sure, feel free to send a patch (could be a macro).


Kind regards,
Petr