[LTP] [PATCH v2] Convert dup01 to new API and clean up

Cyril Hrubis chrubis@suse.cz
Mon Nov 2 13:00:14 CET 2020


Hi!
> +	TEST(dup(fd));
> +	
   ^
   Trailing whitespace
> +	if (TST_RET < -1) { 
                           ^
			   Here as well.

You can use checkpatch.pl from kernel sources to check for these (and a
few more common coding style violations) before submitting.

> +		tst_brk(TBROK, "Invalid dup() return value %ld", TST_RET);

I would argue that this is a TFAIL since TBROK means that test has
failed in preparation phase.


Other than these two minor issues the rest is good.

I can fix these two issues before applying if you agree, no need to send
a v3.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list