[LTP] [PATCH 1/1] fanotify16: Introduce SAFE_FANOTIFY_MARK() macro

Amir Goldstein amir73il@gmail.com
Sun Nov 8 09:43:03 CET 2020


On Tue, Oct 20, 2020 at 10:00 AM Petr Vorel <pvorel@suse.cz> wrote:
>
> Hi Amir,
>
> thanks for your suggestions, I'll send v2 shortly.
> I've been thinking about it for a while and agree it's better to simplify
> safe_fanotify_mark() hints.
> I'll also separate fixes into more commits to be more readable.
>

Hi Petr,

I guess v2 got delayed, so while at it let me ask -
Did you maybe consider also moving the checks for
"FAN_REPORT_FID not supported in kernel?" and
"FAN_REPORT_NAME not supported in kernel?"
into safe_fanotify_init()?

The reason I am asking is because I am working on adding a test case
to fanotify09 [1], which involves converting SAFE_FANOTIFY_INIT()
to fanotify_init(), due to pottenitally unsupported init flags in the kernel.

Thanks,
Amir.

[1] https://github.com/amir73il/ltp/commits/fsnotify-fixes


More information about the ltp mailing list