[LTP] [PATCH] pan/ltp-pan.c: fix file descriptors leaks
Feiyu Zhu
zhufy.jy@cn.fujitsu.com
Mon Nov 9 13:34:31 CET 2020
ltp-pan will leak file descriptors of fopen() into the child process
of the test case, fix this problem by using mode "e" for fopen().
Signed-off-by: Feiyu Zhu <zhufy.jy@cn.fujitsu.com>
---
pan/ltp-pan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pan/ltp-pan.c b/pan/ltp-pan.c
index 8b9fbe5..25e554f 100644
--- a/pan/ltp-pan.c
+++ b/pan/ltp-pan.c
@@ -336,7 +336,7 @@ int main(int argc, char **argv)
if (!strcmp(logfilename, "-")) {
logfile = stdout;
} else {
- if ((logfile = fopen(logfilename, "a+")) == NULL) {
+ if ((logfile = fopen(logfilename, "a+e")) == NULL) {
fprintf(stderr,
"pan(%s): Error %s (%d) opening log file '%s'\n",
panname, strerror(errno), errno,
@@ -453,7 +453,7 @@ int main(int argc, char **argv)
}
if (failcmdfilename) {
- if (!(failcmdfile = fopen(failcmdfilename, "a+"))) {
+ if (!(failcmdfile = fopen(failcmdfilename, "a+e"))) {
fprintf(stderr,
"pan(%s): Error %s (%d) opening fail cmd file '%s'\n",
panname, strerror(errno), errno,
@@ -463,7 +463,7 @@ int main(int argc, char **argv)
}
if (tconfcmdfilename) {
- tconfcmdfile = fopen(tconfcmdfilename, "a+");
+ tconfcmdfile = fopen(tconfcmdfilename, "a+e");
if (!tconfcmdfile) {
fprintf(stderr, "pan(%s): Error %s (%d) opening "
"tconf cmd file '%s'\n", panname,
--
1.8.3.1
More information about the ltp
mailing list