[LTP] [PATCH v3] tcp_cmds/ping/ping02: Make it compatible with Busybox
Petr Vorel
pvorel@suse.cz
Tue Nov 10 15:54:58 CET 2020
Hi Kory, Alexey,
> On 10.11.2020 15:36, Petr Vorel wrote:
> > Hi Kory, Alexey,
> >> -i option was added in busybox 1.30 (2 years old), it'd be good to note that in
> >> the commit message.
> > Actually, maybe also test -i option and if even -i not working run?
> > tst_brk TCONF "unsupported ping version (old busybox?)"
> Hi Petr,
> What if it failed for some other reason, it would be a wrong assumption
> that ping doesn't support -i...
Yep, that'd be bad.
Thus maybe just check
$PING 2>&1 |grep -q -- -i
in case of busybox?
If you don't like it, at least put tst_res TINFO message in case of busybox.
(but I'd prefer this check).
And maybe move $ping_opts and this check to setup.
Kind regards,
Petr
More information about the ltp
mailing list