[LTP] [PATCH v4] tcp_cmds/ping/ping02: Make it compatible with Busybox

[Petr Vorel]

Hi Kory, Alexey,

> >> The ping from busybox does not have -f parameter, use -i parameter instead.
> >> BusyBox does not accept pattern longer than 2 bytes.
> >> BusyBox support -i option since version 1.30

> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > Tested-by: Petr Vorel <pvorel@suse.cz>

> > LGTM.

> > I suggest to merge with few changes below.

> > * more precise message "ping from old busybox?"
> > * use just $(tst_ipaddr rhost) instead of $ipaddr
> > (some time ago we've started to use function calls for these simple evaluations)
> > * upper case for global variable (ugly, but easily recognizable

> Hi Petr,

> Feel free to add the style changes, ack. I've already applied the patch.

> Thanks Kory!

Let's leave it as it is, not that important.
Thanks a lot both.

Kind regards,
Petr